OHRI-1963 Enable editing of L&D form infant details in OHRI #1689
Conversation
| @@ -82,6 +82,17 @@ export function getEstimatedDeliveryDate(patientUuid: string, pTrackerId: string | |||
| }); | |||
| } | |||
|
|
|||
| export function getIdentifierInfo(identifier: string){ | |||
There was a problem hiding this comment.
@kajambiya this function looks solid to me but the only thing missing here is HTTP request & response error handling, would be good if you can add to this function and we show this to the other devs otherwise we will keep having those errors that emerge out of the blue and the user doesn't understand. Here in case an HTTP request or response error happens I would expect to see a message like Failed to retrieve identifier information. Also shouldn't this function be marked as async ?
There was a problem hiding this comment.
Hi @ebambo, All the error handling regarding api calls including http error handling is done in the openmrsFetch function
We don't need to mark the function async because we do not care when it finishes processing. We would have to add async if there was need to await for the operation to first finish.
| export const getIdentifierAssignee = async (identifier: string, identifierType: string) => { | ||
| return getIdentifierInfo(identifier).then((data) => { | ||
| if (data) { | ||
| for (const result of data.results) { |
There was a problem hiding this comment.
What happens if data has no results attribute?
There was a problem hiding this comment.
This comment also applies to the lines below, you better explicitly check or add the question marks
There was a problem hiding this comment.
In this case, by the time we get here, all the other possible errors were checked and the call is fine. If there's no data, it only means that there's no patient with that identifier meaning it's ok to go ahead and assign it to the current patient.
| // only do this the first time the form is entered | ||
| if (sessionMode !== 'enter') { | ||
| if (sessionMode === 'view') { |
There was a problem hiding this comment.
Please update the comment or delete it to indicate the hook runs on both enter and edit
packages/esm-ohri-pmtct-app/src/post-submission-actions/mother-child-linkage-action.ts
Outdated
Show resolved
Hide resolved
| if(existingpTrackerAssignee){ | ||
| if(sessionMode === 'enter'){ |
There was a problem hiding this comment.
Shouldn't this include edit mode?
There was a problem hiding this comment.
Adjusted accordingly
| } else { | ||
| //In edit mode, only throw error if the patient with the existing PTracker is not linked with the current mother | ||
| const parentRelationships = await fetchPatientRelationships(parent.id); | ||
| const isAlreadyLinked = parentRelationships.some( |
Requirements
OHRI-123 My PR title.Summary
Screenshots
Related Issue
Other